afi / afi · cli reviewed proxy at 9b51f95e with Default profile / xAI · grok 4.5 high on afi 0.30.0
Unavailable values retain their exported state and reason
Lifecycle, reviewer, build, settings, and normalized execution limits
1a9fd43b245econfig-e42343de8516eb8cb0f313c0b59a66ecc7612396dc8db0ea5da13a7acomparison-208b6b683dd12ab2build-4ceb7cbd44e9619bcohort-07363c4dd57b37b610b3b2068100b7ba429855e062500eaf83b90120 dirtysha256:a1a935298956020ee6d767a756847abb4c00694c88c2eb80d454886ebc4acf8cNormalized reviewer-tool usage projection
Normalized assessment summary
Review text is escaped; normalized decisions follow each finding
clear_partials` deletes every file in `incoming` with no age/ownership check, so a sweep mid-fetch removes live `BlobWriter` temps and the later `rename` in `commit` fails
services/proxy/src/sweep.rs:224
Evidence quote
Not recorded
Suggested fix
Not recorded
sort_by_key(|c| c.age)` orders youngest first, but eviction assumes oldest first—over-ceiling sweeps remove newly eligible blobs and keep the coldest ones
services/proxy/src/sweep.rs:102
Evidence quote
Not recorded
Suggested fix
Not recorded
forget` always deletes index entries for would-be victims, so `dry_run=true` still unlinks index files and turns hits into misses
services/proxy/src/sweep.rs:140
Evidence quote
Not recorded
Suggested fix
Not recorded
admin calls `sweep` directly and skips `running`, so on-demand and background sweeps can run together and over-delete past the ceiling
services/proxy/src/routes/admin.rs:76
Evidence quote
Not recorded
Suggested fix
Not recorded
values()` emits `sweep_bytes_reclaimed` then `sweep_blobs_removed`, but `COUNTERS` names them in the opposite order, so Prometheus scrapes swapped figures
services/proxy/src/metrics.rs:94
Evidence quote
Not recorded
Suggested fix
Not recorded
a failed `remove_file` still counts the blob toward `removed`/`bytes` and still pushes it to `gone`, so index entries are dropped and metrics report space that was not reclaimed
services/proxy/src/sweep.rs:126
Evidence quote
Not recorded
Suggested fix
Not recorded
the full filesystem walk runs inline on the async worker (also via `admin`’s sync `reclaim`), so a large store stalls the runtime until the sweep finishes
services/proxy/src/sweep.rs:84
Evidence quote
Not recorded
Suggested fix
Not recorded
comment claims symlink size is the link size, but `fs::metadata` follows links and counts the target, so shared/symlinked blobs inflate `held` and trigger excess eviction
services/proxy/src/sweep.rs:164
Evidence quote
Not recorded
Suggested fix
Not recorded
Open a row to inspect or download evidence from this atomically published local run
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link